-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Module Order Warnings for Projects using Mini-Css-Extract-Plugin #192
Fix Module Order Warnings for Projects using Mini-Css-Extract-Plugin #192
Conversation
15780d9
to
79039d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this configurable:
css_extract_ignore_order_warnings
Default can be false.
MAYBE, Version 7 can consider making the default true to suppress warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 👍
Summary
While using a File-System-based automated bundle generation feature, miscellaneous warnings suggesting css order conflicts were encountered due to the
mini-css-extract-plugin.
This PR mutes those warnings by using theignoreOrder
flag which can be configured usingcss_extract_ignore_order_warnings
flag inwebpacker.yml
Tried Solutions
append_stylesheet_pack_tag
andstylesheet_pack_tag
Risks Involved
For projects where CSS order has not been mitigated through consistent use of scoping or naming conventions, the CSS order warnings are essential and may result in visual differences.