Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessor method for nested_entries #176

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

pulkitkkr
Copy link
Contributor

Summary

React on Rails requires access to the nested_entries shakapacker configuration for file-system-based automated bundle generation feature to handle misc edge-cases. This PR adds an accessor method for the nested_entries attribute.

@pulkitkkr pulkitkkr force-pushed the pulkitkkr/expose-nested-enteries branch from 41bba37 to a81d3f4 Compare July 26, 2022 21:33
@pulkitkkr pulkitkkr requested a review from justin808 July 26, 2022 21:33
def nested_entries?
fetch(:nested_entries)
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Tests :)

@pulkitkkr pulkitkkr force-pushed the pulkitkkr/expose-nested-enteries branch 2 times, most recently from 2b8525e to 8bdcd0c Compare July 26, 2022 21:50
@pulkitkkr pulkitkkr force-pushed the pulkitkkr/expose-nested-enteries branch from 8bdcd0c to 0fc9717 Compare July 26, 2022 22:07
@pulkitkkr pulkitkkr requested a review from justin808 July 26, 2022 22:10
@justin808 justin808 merged commit 8a25ef3 into master Jul 26, 2022
@justin808 justin808 deleted the pulkitkkr/expose-nested-enteries branch August 12, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants