Add config.webpacker_precompile #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
Apr 14, 2022
Judahmeek
force-pushed
the
judahmeek/precompile
branch
from
6380c56 to
3e08b80
Compare
Judahmeek
changed the title
justin808
reviewed
Apr 15, 2022
lib/tasks/webpacker/clean.rake
Outdated
| @@ -11,7 +11,7 @@ namespace :webpacker do | |||
| end | |||
| end | |||
|
|
|||
| skip_webpacker_clean = %w(no false n f).include?(ENV["WEBPACKER_PRECOMPILE"]) | |||
| skip_webpacker_clean = %w(no false n f).include?(ENV["WEBPACKER_PRECOMPILE"]) || Webpacker.config.dont_enhance_asset_precompile | |||
Judahmeek
force-pushed
the
judahmeek/precompile
branch
from
500ae0f to
622d189
Compare
justin808
reviewed
Apr 15, 2022
Judahmeek
force-pushed
the
judahmeek/precompile
branch
from
8d46cce to
2434a61
Compare
Judahmeek
changed the title
justin808
reviewed
Apr 15, 2022
justin808
reviewed
Apr 15, 2022
| ENV["WEBPACKER_PRECOMPILE"] = "yes" | ||
|
|
||
| assert Webpacker.config.webpacker_precompile? | ||
| end |
There was a problem hiding this comment.
Needs to test the config file setting, if possible.
There was a problem hiding this comment.
Would be good, might be as simple as setting different value for one of the envs in the test app for now
tomdracz
requested changes
Apr 15, 2022
|
@Judahmeek any ETA for getting this completed? |
Judahmeek
force-pushed
the
judahmeek/precompile
branch
from
2bb1404 to
ac0f634
Compare
justin808
requested changes
Apr 22, 2022
| @@ -7,6 +7,8 @@ default: &default | |||
| public_output_path: packs | |||
| cache_path: tmp/webpacker | |||
| webpack_compile_output: true | |||
| # See https://github.com/shakacode/shakapacker#development | |||
| webpacker_precompile: true | |||
There was a problem hiding this comment.
Eric-Guo
added a commit
to thape-cn/web
that referenced
this pull request
Jun 1, 2022
…precompile' original from shakacode/shakapacker#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the use of a webpacker.yml config value as a complement to
ENV["WEBPACKER_PRECOMPILE"]