Skip module check because it blocks automated installs #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wasare Under what circumstances are you seeing this problem? |
|
The problem occurs in a CI workflow (with github actions). When run pip install -r requirements.txt django is installed along side with your package but the envoirnment does not loaded (or register) the package before install the all dependencies. I understand is a particular case, fixing it i could share the problem and help others. |
shacker
changed the title
|
OK that makes sense to me, and I can't see any downside. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My idea was import django before the check.py to skip the blocking error. Any feedback will be appreciated.