Added Confirmation Before Delete Task #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shacker Review Pull Request and Merge it with master branch |
shacker
reviewed
Feb 3, 2021
| @@ -53,7 +53,7 @@ <h3 class="card-title">{{ task.title }}</h3> | |||
| <form method="post" action="{% url "todo:delete_task" task.id %}" role="form" class="d-inline"> | |||
| {% csrf_token %} | |||
| <div style="display:inline;"> | |||
| <button class="btn btn-danger btn-sm" type="submit" name="submit_delete"> | |||
| <button class="btn btn-danger btn-sm" type="submit" onclick="return confirm('Are you sure to delete task?');" name="submit_delete"> | |||
There was a problem hiding this comment.
Please make it say "Are you sure you want to delete this task?"
shacker
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Hi - Can you please make the language change requested, and also post a couple of screenshots in the PR description, showing what happens when you click either of the two buttons? (as proof that it does delete what it should delete, and doesn't delete if you cancel out). Thanks.
|
@1hanzla100 We never heard back from after the code review above. Did you still want to have this merged? Please respond. |
|
@1hanzla100 Nevermind, I'll just bring it in and change it myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.