Migration to C++17 as default standart (openvinotoolkit#28273)

### Details: - This PR bumps minimum required cxx standart version to C++17, which provides an ability to use advanced features from a more modern standart. - OpenVINO minimum supported compiler version is gcc 8.5 (for RHEL 8.4). Based on https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017 gcc 8 has full c++17 support (with insignificant exceptions), so nothing prevents the upgrade. - MSVC supports c++17 starting with VS 2017 with some fixes in VS 2019 https://learn.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance?view=msvc-170. ### Dependencies: - Disable LTO build on Ubuntu 20: intel-innersource/frameworks.ai.openvino.ci.product-configs#3979 ### Tickets: - [CVS-157537](https://jira.devtools.intel.com/browse/CVS-157537) --------- Co-authored-by: Alina Kladieva <[email protected]>
sgolebiewski-intel · Jan 7, 2025 · 7318165 · 7318165
1 parent e56624a
commit 7318165
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 21 deletions.
diff --git a/cmake/developer_package/compile_flags/os_flags.cmake b/cmake/developer_package/compile_flags/os_flags.cmake
@@ -390,13 +390,7 @@ endif()
 
 # to allows to override CMAKE_CXX_STANDARD from command line
 if(NOT DEFINED CMAKE_CXX_STANDARD)
-    if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
-        set(CMAKE_CXX_STANDARD 14)
-    elseif(OV_COMPILER_IS_INTEL_LLVM)
-        set(CMAKE_CXX_STANDARD 17)
-    else()
-        set(CMAKE_CXX_STANDARD 11)
-    endif()
+    set(CMAKE_CXX_STANDARD 17)
 endif()
 
 if(NOT DEFINED CMAKE_CXX_EXTENSIONS)

diff --git a/docs/snippets/CMakeLists.txt b/docs/snippets/CMakeLists.txt
@@ -107,7 +107,7 @@ endif()
 set(TARGET_NAME "ov_integration_snippet")
 # [cmake:integration_example_cpp]
 cmake_minimum_required(VERSION 3.10)
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 17)
 
 find_package(OpenVINO REQUIRED)
 
@@ -120,7 +120,7 @@ target_link_libraries(${TARGET_NAME} PRIVATE openvino::runtime)
 set(TARGET_NAME_PY "ov_integration_snippet_py")
 # [cmake:integration_example_cpp_py]
 cmake_minimum_required(VERSION 3.10)
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 17)
 
 if(NOT CMAKE_CROSSCOMPILING)
     find_package(Python3 QUIET COMPONENTS Interpreter)
@@ -143,7 +143,7 @@ target_link_libraries(${TARGET_NAME_PY} PRIVATE openvino::runtime)
 set(TARGET_NAME_C "ov_integration_snippet_c")
 # [cmake:integration_example_c]
 cmake_minimum_required(VERSION 3.10)
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 17)
 
 find_package(OpenVINO REQUIRED)
 

diff --git a/samples/cpp/CMakeLists.txt b/samples/cpp/CMakeLists.txt
@@ -95,7 +95,7 @@ endif()
 ####################################
 ## to use C++11; can overwritten via cmake command line
 if(NOT DEFINED CMAKE_CXX_STANDARD)
-    set (CMAKE_CXX_STANDARD 11)
+    set (CMAKE_CXX_STANDARD 17)
     set (CMAKE_CXX_EXTENSIONS OFF)
     set (CMAKE_CXX_STANDARD_REQUIRED ON)
 endif()

diff --git a/src/cmake/openvino.cmake b/src/cmake/openvino.cmake
@@ -30,7 +30,7 @@ add_library(${TARGET_NAME}
 add_library(openvino::runtime ALIAS ${TARGET_NAME})
 set_target_properties(${TARGET_NAME} PROPERTIES EXPORT_NAME runtime)
 
-target_compile_features(${TARGET_NAME} PUBLIC cxx_std_11)
+target_compile_features(${TARGET_NAME} PUBLIC cxx_std_17)
 
 ov_add_vs_version_file(NAME ${TARGET_NAME} FILEDESCRIPTION "OpenVINO runtime library")
 

diff --git a/src/core/template_extension/CMakeLists.txt b/src/core/template_extension/CMakeLists.txt
@@ -3,7 +3,7 @@
 #
 
 # [cmake:extension]
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 17)
 
 set(TARGET_NAME "openvino_template_extension")
 

diff --git a/src/plugins/intel_cpu/CMakeLists.txt b/src/plugins/intel_cpu/CMakeLists.txt
@@ -175,10 +175,6 @@ if(DNNL_USE_ACL)
     set(OV_CPU_WITH_ACL ON)
 endif()
 
-if(OV_CPU_WITH_ACL)
-    set(CMAKE_CXX_STANDARD 14)
-endif()
-
 if (ENABLE_SHL_FOR_CPU)
     add_definitions(-DOV_CPU_WITH_SHL)
     set(OV_CPU_WITH_SHL ON)

diff --git a/tests/memory_tests/CMakeLists.txt b/tests/memory_tests/CMakeLists.txt
@@ -4,7 +4,7 @@
 
 cmake_minimum_required(VERSION 3.13)
 
-set (CMAKE_CXX_STANDARD 11)
+set (CMAKE_CXX_STANDARD 17)
 set (CMAKE_CXX_EXTENSIONS OFF)
 set (CMAKE_CXX_STANDARD_REQUIRED ON)
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

diff --git a/tests/stress_tests/CMakeLists.txt b/tests/stress_tests/CMakeLists.txt
@@ -4,7 +4,7 @@
 
 cmake_minimum_required(VERSION 3.13)
 
-set (CMAKE_CXX_STANDARD 11)
+set (CMAKE_CXX_STANDARD 17)
 set (CMAKE_CXX_EXTENSIONS OFF)
 set (CMAKE_CXX_STANDARD_REQUIRED ON)
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

diff --git a/tests/time_tests/CMakeLists.txt b/tests/time_tests/CMakeLists.txt
@@ -4,7 +4,7 @@
 
 cmake_minimum_required(VERSION 3.13)
 
-set (CMAKE_CXX_STANDARD 11)
+set (CMAKE_CXX_STANDARD 17)
 set (CMAKE_CXX_EXTENSIONS OFF)
 set (CMAKE_CXX_STANDARD_REQUIRED ON)
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

diff --git a/thirdparty/dependencies.cmake b/thirdparty/dependencies.cmake
@@ -474,7 +474,6 @@ if(ENABLE_SNAPPY_COMPRESSION)
             set(SNAPPY_BUILD_BENCHMARKS OFF)
             set(SNAPPY_BUILD_TESTS OFF)
             set(INSTALL_GTEST OFF)
-            set(CMAKE_CXX_STANDARD 14)
             if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
                 # '<': signed/unsigned mismatch
                 ov_add_compiler_flags(/wd4018)