Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref delploy data aka target parser III/V #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blaggacao
Copy link
Contributor

This PR is built cumulatively on top of
two other PRs.

For confidence in review, only the third
commit is meant to be considered.

  • Refactor data to settings (specificity)
  • Refactor data structures into thier own module
  • Refactor implement from_str trait for Target data

Renaming DeployFlake to target better represents the
semantic and making a target string from cli parse()able
perfects that angle of understanding.

Associating methods on the structs they belong to is a pattern
that will also help (in future PRs) to reduce the need for usage
of Copy.

@blaggacao blaggacao changed the title ref delploy data aka target parser ref delploy data aka target parser III/V Aug 11, 2021
@blaggacao blaggacao force-pushed the ref-delploy-data-aka-target-parser branch 2 times, most recently from 77e28b7 to a10cc65 Compare August 26, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant