int: replace the (e)println! with log #51
Conversation
|
Well, I accidentally also changed the |
|
I feel kind of bad that you are doing all the TODOs that never got done :). This is a really needed pr 👍 Just me know when you are ready to to merge it. |
|
Pushed a commit to revert the Should this be a minor version change or a patch version change? |
JiangengDong
force-pushed
the
jiangeng/replace_print_with_log
branch
from
0dd6150
to
7c1d8d5
Compare
|
No worries. Unless there is something more you would like to do in this PR we can just merge this for now, and I am thinking we should make a release that bumps to 0.8 once we make the change static array change. |
JiangengDong
force-pushed
the
jiangeng/replace_print_with_log
branch
from
9ecc51a
to
aad057a
Compare
|
Rebased to the latest master branch, and pushed new commits to increase the version to 0.7.4. I think we can merge this if there is no other concern. |
|
I just merged this but I didn't include the version bump since I don't have time to make a release just now. |
Currently,
r2rprints error messages withprintln!andeprintln!. However, this is not good for debugging, because this is no call site information, and the(e)println!is hard to be silent.In this PR, all the
println!are replaced withlog::debug!and all theeprintln!are replaced withlog::error!. This gives the users more flexibility and better control over the output and makes it easier to locate the problem.