S2reader commons-io dependency issue #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader This should resolve the issue when a module depends on s2msi-reader, snap-core and commons-io. In this case the module does not know where to load the classes from. java.lang.ClassNotFoundException: Will not load class org.apache.commons.io.input.ReversedLinesFileReader arbitrarily from one of ModuleCL@4bc08f13[eu.esa.opt.opttbx.s2msi.reader] and ModuleCL@29091e7a[org.esa.snap.snap.core] starting from ModuleCL@e56c0cf[org.eomasters.eomtbx] Moved commons-io dependency from opttbx-s2msi-reader to snap-core to centralize its usage. This ensures consistent versioning across modules and avoids redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved commons-io dependency from opttbx-s2msi-reader to snap-core to centralize its usage. This ensures consistent versioning across modules and avoids redundancy.
see also: https://forum.step.esa.int/t/commons-io-dependency-issue-in-s2msi-reader/44516
This should resolve the issue when a module depends on s2msi-reader, snap-core and commons-io. In this case the module does not know where to load the classes from.
java.lang.ClassNotFoundException: Will not load class org.apache.commons.io.input.ReversedLinesFileReader arbitrarily from one of ModuleCL@4bc08f13[eu.esa.opt.opttbx.s2msi.reader] and ModuleCL@29091e7a[org.esa.snap.snap.core] starting from ModuleCL@e56c0cf[org.eomasters.eomtbx]There is a related pull request for the opttbx senbox-org/optical-toolbox#112