Fix error callback with custom transport #5981

KrzysztofBogdan · 2021-02-11T13:02:32Z

If custom transport does not return any object
then calling error callback would result in Uncaught TypeError: right-hand side of 'in' should be an object, got undefined.
This patch adds check if $request evaluates to something.

This pull request includes a

Bug fix

The following changes were made

Check if transport method returned data

If custom transport does not return any object then calling error callback would result in `Uncaught TypeError: right-hand side of 'in' should be an object, got undefined`. This patch adds check if $request evaluates to something.

KrzysztofBogdan · 2021-02-11T13:06:04Z

As documentation example shows in
https://select2.org/data-sources/ajax

This should work:

  ajax: {
    transport: function (params, success, failure) {
      var request = new AjaxRequest(params.url, params);
      request.on('success', success);
      request.on('failure', failure);
    }

but there will be error while calling failure callback

If custom transport does not return any object then calling error callback would result in `Uncaught TypeError: right-hand side of 'in' should be an object, got undefined`. This patch adds check if $request evaluates to something.

Fix error callback with custom transport

b896388

If custom transport does not return any object then calling error callback would result in `Uncaught TypeError: right-hand side of 'in' should be an object, got undefined`. This patch adds check if $request evaluates to something.

kevin-brown added 4.x feature: ajax status: pending PR merge enhancement labels Feb 23, 2021

kevin-brown removed the status: pending PR merge label Mar 4, 2021

kevin-brown merged commit 0a30b0b into select2:develop Mar 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix error callback with custom transport #5981

Fix error callback with custom transport #5981

KrzysztofBogdan commented Feb 11, 2021 •

edited by kevin-brown

Loading

KrzysztofBogdan commented Feb 11, 2021 •

edited

Loading

Fix error callback with custom transport #5981

Fix error callback with custom transport #5981

Conversation

KrzysztofBogdan commented Feb 11, 2021 • edited by kevin-brown Loading

KrzysztofBogdan commented Feb 11, 2021 • edited Loading

KrzysztofBogdan commented Feb 11, 2021 •

edited by kevin-brown

Loading

KrzysztofBogdan commented Feb 11, 2021 •

edited

Loading