Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum jQuery version to latest in the 1.x series #5525

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

blikblum
Copy link
Contributor

@blikblum blikblum commented Jun 1, 2019

This pull request includes a

  • Bug fix
  • New feature
  • Translation
  • Cleanup

The following changes were made

  • Utils.appendMany
  • Update jquery test version from 1.7.2 to 1.12.4

Utils.appendMany is used to support jquery version 1.7 which is long outdated. jquery v1 is still supported by the latest 1.x version

@kevin-brown kevin-brown added this to the 4.1.0 milestone Jun 5, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Aug 4, 2019
@kevin-brown
Copy link
Member

kevin-brown commented Aug 5, 2019

I have put this in the 4.1.0 milestone because this is slightly backwards-incompatible and I would rather not have it go out in a patch version.

@stale stale bot removed the status: stale label Aug 5, 2019
@stale
Copy link

stale bot commented Oct 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kevin-brown
Copy link
Member

Marking this as needing a rebase but it's slated to roll into the 4.1.0 release again.

@kevin-brown kevin-brown changed the title Remove Utils.appendMany Increase minimum jQuery version to latest in the 1.x series Feb 4, 2020
@kevin-brown kevin-brown merged commit 4bd4bbc into select2:develop Mar 14, 2020
DavidMoraisFerreira added a commit to DavidMoraisFerreira/select2-customSelectionAdapter that referenced this pull request Mar 6, 2022
…apter with the latest Select2 release candidate

BREAKING CHANGE: Raises required JQuery version (select2/select2#5525)
DavidMoraisFerreira added a commit to DavidMoraisFerreira/select2-customSelectionAdapter that referenced this pull request Mar 6, 2022
…lect2@latest

BREAKING CHANGE: Raises required JQuery version (select2/select2#5525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants