-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Hebrew translations #3911
Conversation
Let me start off by saying thanks for contributing updated translations to Select2. This is a community-driven project, and we're always glad to see solutions from those who use the plugin. I personally don't know Hebrew well enough to be able to judge this change, and unfortunately this isn't a change where I can do a small amount of research to confirm the wording that is being used. The normal solution is for a small explanation of the changes to be included, so we (as the maintainers) can understand why the change is being made, and others can verify the accuracy. |
About `errorLoading`: Before the correction, the translation was: "התוצאות לא נטענו בהלכה". The word "בהלכה" is wrong and should be spelled "כהלכה", but besides that, this translations means "The results were loaded improperly", while my corrected translation means "Error while loading results", which is what needed. About `inputTooLong`, `inputTooShort`, `maximumSelected`: In Hebrew, it's not acceptable to have the digit 1 for representing a single object. You should use the actual word "one", which is "אחד" in Hebrew together with the singular noun (e.g. "one item" / "one character", instead of "1 item" / "1 character"). **These 3 parts needed a critical fix anyway**, because they were addind the English letter 's' to the end of the Hebrew string. About `loadingMore`: The translation was "טען תוצאות נוספות" which means "Load more results", as an instruction, probably a typo. I changed "טען" to "טוען" so now it means "loading more results", which is the correct form.
@kevin-brown Here are the explanations: About About About |
I fixed a few whitespace issues (nothing major) and squashed the commits into 7974fd1, which is now sitting on the master branch and will be included in the upcoming 4.0.1 release. |
@kevin-brown Actually, if mentioning whitespaces clean up, can I ask if there's a specific reason why you didn't use if shorthands in this file ("ternary operator", |
That's the main reason. For many languages, there tends to be multiple levels of nesting necessary to determine the right suffixes, and doing it with a ternary operator tends to create a mess. Compare It was also done for consistency reasons, as the large majority of the code base favors the traditional |
I just found out that the minified version turns the conditions and declelations into a very compressed form, including a use of ternary. By the way, I'll be grateful if you can provide fetching instructions in short. I was exposed to Bower and other modern JS tools and package managers only recently, and I wasn't sure how to fetch a minified version of Select2 by myself, since I saw both composer.json and bower.json files in the package root dir. |
About `errorLoading`: Before the correction, the translation was: "התוצאות לא נטענו בהלכה". The word "בהלכה" is wrong and should be spelled "כהלכה", but besides that, this translations means "The results were loaded improperly", while my corrected translation means "Error while loading results", which is what needed. About `inputTooLong`, `inputTooShort`, `maximumSelected`: In Hebrew, it's not acceptable to have the digit 1 for representing a single object. You should use the actual word "one", which is "אחד" in Hebrew together with the singular noun (e.g. "one item" / "one character", instead of "1 item" / "1 character"). **These 3 parts needed a critical fix anyway**, because they were addind the English letter 's' to the end of the Hebrew string. About `loadingMore`: The translation was "טען תוצאות נוספות" which means "Load more results", as an instruction, probably a typo. I changed "טען" to "טוען" so now it means "loading more results", which is the correct form. This closes select2#3911
No description provided.