Apply select2('option') calls on all elements #3495
Conversation
|
The tests pass, but I could have broken another string option. However, 'destroy' seems to be the only documented one. If this is indeed the only option in 4.0, then (This is a 4.0 pull request.) |
|
|
Thank you @kevin-brown for your answer! However, I'm not going to work on a fixed version of this pull request. I actually changed the way I use select2 to not use 'destroy'. I hope I still helped the project a little bit. |
This fixes an issue when any of Select2's special options are called on
multiple elements, it would only affect the first option in the group.
This was because Select2 was only applying any changes to the first
element in the group (as chosen by jQuery) instead of applying changes
on each and every element within the list.
This has the new side effect of special options like `select2('data')`
returning the results for the last element in the list instead of the
first element. Because the previous functionality was considered
unspecified behaviour, this is not being treated as a breaking change.
This closes select2#3413
This closes select2#3495
Fixes #3413
The idea of the patch is simple: as with
'object'options, we iterate overthis.I don't know how to test destroy(), so... I did not test it. I might give it a try with some guidance. Should dist/ changes be part of the pull request? This is not mentioned in CONTRIBUTING.md.