Add !important to .select2-hidden-accessible.
#3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.select2-hidden-accessible` is the CSS class that is added to the original `<select>` element (that Select2 is initialized on) to hide it. In cases where the original `<select>` has other style declarations assigned which conflict with those of `.select2-hidden-accessible`, the latter styles may be overridden, possibly resulting in the original `<select>` element not being properly hidden. Similar to what select2#1549 did for Select2 v3's CSS, this adds the `!important` rule to all style declarations for `.select2-hidden-accessible` to make it exponentially harder to override them.
kevin-brown
added a commit
that referenced
this pull request
Apr 30, 2015
Add `!important` to `.select2-hidden-accessible`.
|
Thanks! |
fk
pushed a commit
to select2/select2-bootstrap-theme
that referenced
this pull request
Jun 18, 2015
… until this lands in Select2's default CSS with v4.0.1 (select2/select2#3301). Fix bad documentation along the way (hopefully ;-)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.select2-hidden-accessibleis the CSS class that is added to the original<select>element (that Select2 is initialized on) to hide it.In cases where the original
<select>has other style declarations assigned which conflict with those of.select2-hidden-accessible, the latter styles may be overridden, possibly resulting in the original<select>element not being properly hidden.Similar to what #1549 did for Select2 v3's CSS, this adds the
!importantrule to all style declarations for.select2-hidden-accessibleto make it exponentially harder to override them.