Prevent selections from being removed when disabled

This prevents selections from being removed when the container is disabled. This stops any click events that are triggered on the remove button, so the remove handler won't be triggered at all. This closes #3636.
select2 · Aug 20, 2015 · 68d068f · 68d068f
1 parent 7d8f86c
commit 68d068f
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/src/js/select2/selection/multiple.js b/src/js/select2/selection/multiple.js
@@ -32,18 +32,26 @@ define([
       });
     });
 
-    this.$selection.on('click', '.select2-selection__choice__remove',
+    this.$selection.on(
+      'click',
+      '.select2-selection__choice__remove',
       function (evt) {
-      var $remove = $(this);
-      var $selection = $remove.parent();
+        // Ignore the event if it is disabled
+        if (self.options.get('disabled')) {
+          return;
+        }
 
-      var data = $selection.data('data');
+        var $remove = $(this);
+        var $selection = $remove.parent();
 
-      self.trigger('unselect', {
-        originalEvent: evt,
-        data: data
-      });
-    });
+        var data = $selection.data('data');
+
+        self.trigger('unselect', {
+          originalEvent: evt,
+          data: data
+        });
+      }
+    );
   };
 
   MultipleSelection.prototype.clear = function () {