Remove UNREACHABLE() from resolveAddressBits
#1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary verification tools do not support __builtin_unreachable. Signed-off-by: Nick Spinale <[email protected]>
axel-h
reviewed
Nov 6, 2024
| @@ -190,6 +190,4 @@ resolveAddressBits_ret_t resolveAddressBits(cap_t nodeCap, cptr_t capptr, word_t | |||
| return ret; | |||
| } | |||
| } | |||
|
|
|||
| UNREACHABLE(); | |||
There was a problem hiding this comment.
Can't we keep this in the code and just change the define for a verification run to become nothing? It might still be useful to see compiler warnings if this such places can be reached.
There was a problem hiding this comment.
Given that we prove we don't reach this point (the semantics doesn't allow us to fall off the end of a C function), I don't think that is really necessary for resolveAddressBits.
In general I would not mind a conditional macro definition for situations where UNREACHABLE is used in debug code or other parts that are not in scope for verification, but it's perfectly fine to merge this as is.
lsf37
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary verification tools do not support
__builtin_unreachable, andresolveAddressBitsis in scope for binary verification.