-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install target fails for the verified ARM_HYP configuration #1334
Comments
wucke13
added a commit
to DLR-FT/seL4-nix-utils
that referenced
this issue
Oct 28, 2024
Hotfix for seL4/seL4#1334
wucke13
added a commit
to DLR-FT/seL4-nix-utils
that referenced
this issue
Oct 28, 2024
Hotfix for seL4/seL4#1334
wucke13
added a commit
to DLR-FT/seL4-nix-utils
that referenced
this issue
Oct 28, 2024
Hotfix for seL4/seL4#1334
kent-mcleod
added a commit
to kent-mcleod/seL4
that referenced
this issue
Oct 28, 2024
The source layout for arm_hyp configurations uses a symlink to redirect sel4_arch include paths back to aarch32 when KernelSel4Arch is set to arm_hyp. This case wasn't being handled by the CMake install target for installing libsel4 and kernel.elf when the project is used in a standalone context. The consequence is that the ARM_HYP verified configurations would fail to install even though they would build correctly. We directly address this issue by accounting for the arm_hyp special case in the installation command where we manually resolve the symlink. If new arm_hyp symlinks are added in the future, this fix should still apply providing that the update to the CMake install target uses the same resolved sel4arch path variable introduced by this change. There is a longer-term plan to remove the arm_hyp KernelSel4Arch config value which is expected to remove these sorts of issues. Signed-off-by: Kent McLeod <[email protected]>
kent-mcleod
added a commit
to kent-mcleod/seL4
that referenced
this issue
Oct 28, 2024
The source layout for arm_hyp configurations uses a symlink to redirect sel4_arch include paths back to aarch32 when KernelSel4Arch is set to arm_hyp. This case wasn't being handled by the CMake install target for installing libsel4 and kernel.elf when the project is used in a standalone context. The consequence is that the ARM_HYP verified configurations would fail to install even though they would build correctly. We directly address this issue by accounting for the arm_hyp special case in the installation command where we manually resolve the symlink. If new arm_hyp symlinks are added in the future, this fix should still apply providing that the update to the CMake install target uses the same resolved sel4arch path variable introduced by this change. There is a longer-term plan to remove the arm_hyp KernelSel4Arch config value which is expected to remove these sorts of issues. Signed-off-by: Kent McLeod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Command to reproduce:
nix build github:DLR-FT/seL4-nix-utils/7292affcd7fa8ca739a29a1684fb795a6f1189e5\#seL4-kernel-arm-hyp --print-build-logs
Actual error message:
Notes:
ninja install
. Not many seL4 projects provide an install target, but the kernel itself does. @nspin is using this for the upstream Rust code, so I'm not sure if its feasible to just remove the install target all-together.Full build log
The text was updated successfully, but these errors were encountered: