EC2: Provide comments with context.

The comment is useful just as a commit message: This isn't in it's final form. It is expected that eventually the ec2 client will be passed in via the constructor of the environ. That can then be passed in via the environProvider. Unfortunately the provider (factory) is registered in an init function and makes it VERY hard to override. The solution to all of this is to remove the global registry and construct that within the main (or provide sane defaults). The provider/all package can then be removed and the black magic for provider registration can then vanish and plain old dependency management can then be used.
sdg0919 · Jun 16, 2021 · cb4f27d · cb4f27d
1 parent ac0a161
commit cb4f27d
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/provider/ec2/environ.go b/provider/ec2/environ.go
@@ -2540,6 +2540,16 @@ func (e *environ) SetCloudSpec(ctx stdcontext.Context, spec environscloudspec.Cl
 	// Allow the passing of a client func through the context. This allows
 	// passing the client from outside of the environ, one that allows for
 	// custom http.Clients.
+	//
+	// This isn't in it's final form. It is expected that eventually the ec2
+	// client will be passed in via the constructor of the environ. That can
+	// then be passed in via the environProvider. Unfortunately the provider
+	// (factory) is registered in an init function and makes it VERY hard to
+	// override. The solution to all of this is to remove the global registry
+	// and construct that within the main (or provide sane defaults). The
+	// provider/all package can then be removed and the black magic for provider
+	// registration can then vanish and plain old dependency management can
+	// then be used.
 	if value := ctx.Value(AWSClientContextKey); value == nil {
 		e.ec2ClientFunc = clientFunc
 	} else if s, ok := value.(ClientFunc); ok {