Verify origin ID in retrieveLatestCharmInfo.

sdg0919 · Oct 26, 2021 · b758d11 · b758d11
1 parent afb6855
commit b758d11
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/apiserver/facades/controller/charmrevisionupdater/updater.go b/apiserver/facades/controller/charmrevisionupdater/updater.go
@@ -183,8 +183,8 @@ func (api *CharmRevisionUpdaterAPI) retrieveLatestCharmInfo() ([]latestCharmInfo
 				logger.Errorf("charm %s has no origin, skipping", curl)
 				continue
 			}
-			if origin.Revision == nil || origin.Channel == nil || origin.Platform == nil {
-				logger.Errorf("charm %s has missing revision (%p), channel (%p), or platform (%p), skipping",
+			if origin.ID == "" || origin.Revision == nil || origin.Channel == nil || origin.Platform == nil {
+				logger.Errorf("charm %s has missing id(%s), revision (%p), channel (%p), or platform (%p), skipping",
 					curl, origin.Revision, origin.Channel, origin.Platform)
 				continue
 			}