-
-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #30438
🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #30438
Conversation
bf3638a
to
f1c468d
Compare
The failure is caused by a change in the output in the HDBSCAN output:
This is caused by a change in the https://numpy.org/devdocs/release/2.2.0-notes.html#changes Personally, I like the fact that the shape is displayed by default. However, this will make the doctest difficult to work with both old and new versions numpy. I will try to update this doctest to make it not rely on the |
I pushed 0c1088d. Please let me know what you think about it. If we merge this, we might want to cherry-pick that commit for the |
Since I pushed 0c1088d into this PR, I'll wait for others to review instead of directly merging as usual. |
The work-around seems fine to me. Maybe using
The approach we have taken historically is to only run the doctests in some settings, for example we could only run them in numpy >= 2.2.0. |
Co-authored-by: Lock file bot <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Lock file bot <[email protected]> Co-authored-by: Olivier Grisel <[email protected]>
Update lock files.
Note
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.