Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 🤖 CI Update lock files for free-threaded CI build(s) 🔒 🤖 #30385

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

Copy link

github-actions bot commented Dec 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e16b12c. Link to the linter CI: here

@ogrisel
Copy link
Member

ogrisel commented Dec 2, 2024

The failures are not caused by free-threading nor a change in its dependencies, but by a dtype change for the integer arrays internally used in scipy dev sparse matrices: #30384 and #30377.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure already happened in main and is unrelated to the updates of dependencies in this PR.

So +1 for merging irrespective of the failure on my end.

@jeremiedbb jeremiedbb enabled auto-merge (squash) December 2, 2024 12:37
@jeremiedbb jeremiedbb disabled auto-merge December 2, 2024 12:40
@jeremiedbb jeremiedbb merged commit 1c20f1e into scikit-learn:main Dec 2, 2024
32 of 34 checks passed
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 4, 2024
jeremiedbb pushed a commit that referenced this pull request Dec 6, 2024
virchan pushed a commit to virchan/scikit-learn that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants