Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Use conda for free threaded build #30312

Merged
merged 8 commits into from
Nov 20, 2024
Merged

CI Use conda for free threaded build #30312

merged 8 commits into from
Nov 20, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Nov 20, 2024

This allows to have a similar setup as all the other builds and also to have the lock-file updated automatically weekly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5d51d3a. Link to the linter CI: here

jeremiedbb
jeremiedbb approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If I understood correctly, after merging this, we'll expect a fifth bot PR every monday to update the lock file for the free threaded job, right ?

@lesteve
Copy link
Member Author

lesteve commented Nov 20, 2024 •
edited
Loading

If I understood correctly, after merging this, we'll expect a fifth bot PR every monday to update the lock file for the free threaded job, right ?

Yes exactly.

Full disclosure: the mixed approach conda lock-file + manual pip install in build_tools/install.sh is a temporary work-around for now.

I originally planned to install use pip_dependencies for most dependencies since right now free-threaded wheels are more likely to be available than conda-forge packages (see conda-forge/conda-forge-pinning-feedstock#6673 for example for a discussion about conda-forge status with free-threaded). The fact that conda-lock is not able to deal with free-threaded wheels conda/conda-lock#754 made me reconsider ...

We can always adapt the approach depending on how the free-threaded situation evolves in the future ...

glemaitre
glemaitre approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a weekly fun with this new Python ;)

@glemaitre glemaitre merged commit 4f2159c into scikit-learn:main Nov 20, 2024
31 checks passed
@lesteve lesteve deleted the use-conda-for-free-threaded-build branch November 21, 2024 15:02
@lesteve lesteve mentioned this pull request Nov 25, 2024
Merged
@lesteve lesteve added the free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703) label Nov 28, 2024
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 4, 2024
@lesteve @jeremiedbb
CI Use conda for free threaded build (scikit-learn#30312)
e7c0568
jeremiedbb pushed a commit that referenced this pull request Dec 6, 2024
@lesteve @jeremiedbb
CI Use conda for free threaded build (#30312)
6ab2c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Build / CI free-threading PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @glemaitre @jeremiedbb