✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: ee76a50. Link to the linter CI: here}

This removes the public(ish?) sklearn.utils.estimator_checks.check_estimator_get_tags_default_keys in favor of check_valid_tag_types so now in a CI run that uses nilearn I get an import failure:

...
/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/nilearn/maskers/multi_nifti_masker.py:23: in <module>
    from nilearn._utils.class_inspect import (
/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/nilearn/_utils/class_inspect.py:3: in <module>
    from sklearn.utils.estimator_checks import (
E   ImportError: cannot import name 'check_estimator_get_tags_default_keys' from 'sklearn.utils.estimator_checks' (/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/site-packages/sklearn/utils/estimator_checks.py)

Would it make sense to add a trivial check_estimator_get_tags_default_keys = check_valid_tag_types backward compat wrapper here or would that be too ugly?

Would it make sense to add a trivial check_estimator_get_tags_default_keys = check_valid_tag_types

It is true that this one kind of public. I would be in favor of introducing an alias. @adrinjalali WDYT?

That test is really for Tags which are introduced in this release. I understand keeping the CI green during this cycle (and probably the upcoming cycle 🙈 ) hasn't been the best experience, but I don't think we should give that alias. Also, the old name really doesn't reflect what the test does, and if devs are doing something using the name, the chances are they might not be doing the same thing with the new test.

Makes sense to me, thanks -- forgot this was within-cycle!