-
-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Add link to Quantile example in Gradient Boosting #30266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @Akankshaaaa.
The references are well placed, but I think the first one at the loss
param is enough, since all the use cases when people would set the alpha
param involve a certain loss anyways and then users would see the same link in two different places for the same use case, which is too much.
Thus, I would suggest to remove the second reference.
And a little nit on the first reference.
Co-authored-by: Stefanie Senger <[email protected]>
Yes, that makes sense. I have committed your suggestion. |
Yes, and I would also remove the second reference, @Akankshaaaa. |
removed second reference
@StefanieSenger done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you.
I think this can now be merged. 🍾
Would you mind, @adrinjalali ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Akankshaaaa
Reference Issues/PRs
References #26927
What does this fix?
Added links to gradient boosting quantile example in docs