Skip to content

Conversation

@larsoner
Copy link
Contributor

It's useful to know when this function was added to sklearn.utils so I can maintain compat with old versions while developing for latest dev.

@larsoner
Copy link
Contributor Author

(chose version just based on looking at the doc but maybe it was available before 1.6/dev?)

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e6192aa. Link to the linter CI: here

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @larsoner.

Notes
-----
.. versionadded:: 1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually don't place these in the Notes section but rather at the end of the description, right before the Parameters section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thomasjpfan thomasjpfan added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Nov 12, 2024
@thomasjpfan thomasjpfan added this to the 1.6 milestone Nov 12, 2024
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks

@jeremiedbb jeremiedbb merged commit 200fc7c into scikit-learn:main Nov 12, 2024
34 checks passed
jeremiedbb pushed a commit to glemaitre/scikit-learn that referenced this pull request Nov 14, 2024
jeremiedbb pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation module:utils To backport PR merged in master that need a backport to a release branch defined based on the milestone.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants