-
-
Notifications
You must be signed in to change notification settings - Fork 26.5k
DOC: Document version added #30264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Document version added #30264
Conversation
|
(chose version just based on looking at the doc but maybe it was available before 1.6/dev?) |
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @larsoner.
sklearn/utils/_tags.py
Outdated
| Notes | ||
| ----- | ||
| .. versionadded:: 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually don't place these in the Notes section but rather at the end of the description, right before the Parameters section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
thomasjpfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeremiedbb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks
It's useful to know when this function was added to
sklearn.utilsso I can maintain compat with old versions while developing for latest dev.