TST add formatting strings to check_regressor_multioutput assertion #30241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Nov 8, 2024
sklearn/utils/estimator_checks.py
Outdated
| @@ -2080,7 +2080,7 @@ def check_regressor_multioutput(name, estimator): | |||
| ) | |||
| assert y_pred.shape == y.shape, ( | |||
| "The shape of the prediction for multioutput data is incorrect." | |||
| " Expected {}, got {}." | |||
| " Expected {}, got {}.".format(y_pred.shape, y.shape) | |||
There was a problem hiding this comment.
you can simply use f-strings here
OmarManzoor
approved these changes
Nov 13, 2024
adrinjalali
approved these changes
Nov 14, 2024
jeremiedbb
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 14, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
closes #30238
What does this implement/fix? Explain your changes.
Add formatting strings according to issue.