CI generate changelog in doc ci #30231
Conversation
| @@ -262,7 +262,8 @@ package = "sklearn" # name of your package | |||
|
|
|||
| [tool.towncrier] | |||
| package = "sklearn" | |||
| filename = "doc/whats_new/notes-towncrier.rst" | |||
| filename = "doc/whats_new/v1.6.rst" | |||
There was a problem hiding this comment.
This is something that we discussed with @lesteve. Basically, we will need to bump this version at each major release for the next one. We can check later if we can automatized this but for the moment I think this is fine.
There was a problem hiding this comment.
so we should also make sure this step is included in the "how to release guide
There was a problem hiding this comment.
Yes. My plan is to make an update during the upcoming release process.
|
@ogrisel @adrinjalali @jeremiedbb This PR is now generating the changelog in |
| @@ -262,7 +262,8 @@ package = "sklearn" # name of your package | |||
|
|
|||
| [tool.towncrier] | |||
| package = "sklearn" | |||
| filename = "doc/whats_new/notes-towncrier.rst" | |||
| filename = "doc/whats_new/v1.6.rst" | |||
There was a problem hiding this comment.
so we should also make sure this step is included in the "how to release guide
| if [[ "$CIRCLE_BRANCH" =~ ^main$ || -n "$CI_PULL_REQUEST" ]] | ||
| then |
There was a problem hiding this comment.
Such that we have an changelog published on the /dev website as well. I thought that it could be handy.
closing #30220
Trying to generate the changelog in the documentation CI to be able to check the changelog generation when reviewing.