MAINT Clean up deprecations for 1.6: in ColumnTransformer #30215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
added
No Changelog Needed
Quick Review
adrinjalali
reviewed
Nov 5, 2024
| ct.fit_transform(df) | ||
| ct.set_output(transform="default") | ||
|
|
||
| # No warning when there are no pd.NA |
Member
There was a problem hiding this comment.
Suggested change
| # No warning when there are no pd.NA | |
| # No errors when there are no pd.NA |
ogrisel
approved these changes
Nov 5, 2024
| """Check behavior when a tranformer's output contains pandas.NA | ||
| It should emit a warning unless the output config is set to 'pandas'. | ||
| It should emit an error unless the output config is set to 'pandas'. |
Member
There was a problem hiding this comment.
Suggested change
| It should emit an error unless the output config is set to 'pandas'. | |
| It should raise an error unless the output config is set to 'pandas'. |
thomasjpfan
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from warning to error when there are
pandas.NAbut output is not set to pandas.