DOC Fix gramatical error in governence #30210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Nov 4, 2024
doc/governance.rst
Outdated
Comment on lines
160
to
162
| * **Changes to the API principles and changes to dependencies or supported | ||
| versions** happen via a :ref:`slep` and follows the decision-making process | ||
| versions** happen via an :ref:`slep` and follows the decision-making process | ||
| outlined above. |
There was a problem hiding this comment.
Instead, you can do
* **Changes to the API principles and changes to dependencies or supported versions**
happen via :ref:`Enhacement Proposals (SLEPs) <slep>` and follows the
decision-making process outlined above.
adrinjalali
changed the title
|
Please apply the issues from #30181 in the same PR. |
rajathkannabiran
force-pushed
the
Fix_issue_30180
branch
from
17921dc to
aec945f
Compare
|
@adrinjalali made the recommended change and included #30181 too in this PR. Please review |
adrinjalali
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #30180 and #30181
What does this implement/fix? Explain your changes.
Fixing a simple grammatical mistake in https://scikit-learn.org/stable/governance.html
as per Issue #30180 by @AdityaInnovates