Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Bump macOS version to 13 on Azure #30185

Merged
merged 29 commits into from
Nov 4, 2024
Merged

CI Bump macOS version to 13 on Azure #30185

merged 29 commits into from
Nov 4, 2024

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Oct 31, 2024 •
edited by lesteve
Loading

See actions/runner-images#10721. macOS-12 removal on Azure is scheduled for December 2024, brownout windows will start in November 2024.

@glemaitre glemaitre marked this pull request as draft October 31, 2024 09:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 0ec617d. Link to the linter CI: here

@glemaitre glemaitre mentioned this pull request Oct 31, 2024
Closed
lesteve
lesteve reviewed Oct 31, 2024
View reviewed changes
build_tools/azure/install_setup_conda.sh Outdated
echo "##vso[task.prependpath]$CONDA/bin"

# Take ownership of conda installation
sudo chown -R $USER $CONDA
Copy link
Member

@lesteve lesteve Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need this only when conda is installed so maybe put it in a else clause of if [[ -z "${CONDA}" ]]?

IIRC CONDA is a system folder which somehow causes issue somewhere ...

@glemaitre glemaitre force-pushed the try_install_miniforge branch from 7ee870c to 53dbe9f Compare October 31, 2024 14:13
@glemaitre glemaitre marked this pull request as ready for review October 31, 2024 14:23
@lesteve lesteve changed the title [DEBUG] try to install miniforge on MacOS runner in Azure pipeline CI Bump macOS version to 13 on Azure Oct 31, 2024
@lesteve
Copy link
Member

lesteve commented Oct 31, 2024

I pushed some simplification for the script which hopefully should not break things too much 🤞

@glemaitre
Copy link
Member Author

Nice @lesteve

lesteve
lesteve approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping at it until it worked!

jeremiedbb
jeremiedbb approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiedbb jeremiedbb merged commit 44017bb into scikit-learn:main Nov 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @lesteve @jeremiedbb