Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC redirect to GitHub issues & PR instead of mailing list when it comes to contribution #30177

Merged
merged 4 commits into from
Oct 30, 2024
Merged

DOC redirect to GitHub issues & PR instead of mailing list when it comes to contribution #30177

merged 4 commits into from
Oct 30, 2024

Conversation

MarieSacksick
Copy link
Contributor

... instead of mailing list

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Orient people towards the most used tools instead of mailing list, also to avoid spam.

Any other comments?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e8c9207. Link to the linter CI: here

glemaitre
glemaitre approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I think that it would be our prefer channel of communication.

@glemaitre glemaitre changed the title doc(contributing): update contributing to orient toward gh and discord DOC redirect to GitHub issues & PR instead of mailing list when it comes to contribution Oct 30, 2024
glemaitre
glemaitre approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @MarieS-WiMLDS

@glemaitre glemaitre enabled auto-merge (squash) October 30, 2024 15:16
@glemaitre
Copy link
Member

Enabling auto-merge.

ogrisel
ogrisel approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarieS-WiMLDS. For background, we discussed this suggestion IRL because younglings do not know what mailing list are anymore ;)

@glemaitre glemaitre disabled auto-merge October 30, 2024 15:24
@glemaitre
Copy link
Member

Disable the auto-merge to take @ogrisel comments into account before merging.

@glemaitre glemaitre enabled auto-merge (squash) October 30, 2024 16:27
@glemaitre glemaitre merged commit d3e86ff into scikit-learn:main Oct 30, 2024
28 checks passed
@MarieSacksick MarieSacksick deleted the update_contributing_com_with_modern_communication branch October 30, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarieSacksick @glemaitre @ogrisel