DOC use pydata-sphinx-theme for the website #29038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into new_web_theme
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Adrin Jalali <[email protected]>
…es (#28623) Co-authored-by: Guillaume Lemaitre <[email protected]>
|
Did we remove the |
|
Yes, as suggested in #28379 (comment). I'm adding it back in #29037, which should be merged into |
8 tasks
glemaitre
changed the title
|
I made the last changes and pushed a full rebuild. |
jeremiedbb
approved these changes
May 20, 2024
There was a problem hiding this comment.
All green. I quickly skimmed trough the generated web site and everything looks good. Thanks @Charlie-XIAO !
glemaitre
approved these changes
May 20, 2024
|
Will we get this theme for the 1.5 website (aka the one people will see under It would be nice to get it out, but given how little time there is between now and the release of 1.5 it might be smart to use the old theme for 1.5 and have this on the |
|
Basically, I would not delay and have the theme for 1.5. We had iteration in the branch |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 21, 2024
Co-authored-by: Yao Xiao <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
jeremiedbb
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: Yao Xiao <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
|
Thank you for this work, @Charlie-XIAO! 💯 |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Yao Xiao <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
glemaitre
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Yao Xiao <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]>
drammock
pushed a commit
to pydata/pydata-sphinx-theme
that referenced
this pull request
Sep 20, 2024
Thanks for the amazing theme! Scikit-learn has migrated to pydata-sphinx-theme for the main website since version 1.5 (scikit-learn/scikit-learn#29038), and the nice three-column layout has unlocked many potential improvements to our website UI/UX-wise. This PRs adds scikit-learn to the list of `Other projects using this theme`. However though scikit-learn is not one of the earliest adopters of pydata-sphinx-theme, I'm asking if it can fit into the list of `Featured projects` as we have many quite some customizations that could be helpful for other users of the theme. Some of them include: - [Landing page](https://scikit-learn.org/) - [API references](https://scikit-learn.org/stable/api/index.html) (a searchable table on the index page containing all APIs while keeping the hierarchy in the primary sidebar) - [Each API page](https://scikit-learn.org/stable/modules/generated/sklearn.linear_model.LogisticRegression.html) (customizing the secondary sidebar) - [Gallery examples](https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_5_0.html) (secondary sidebar customization with sphinx-gallery) - [Platform-specific installation instructions](https://scikit-learn.org/stable/install.html#installing-the-latest-release) (CSS customizations based on tabs in sphinx-design) - [Dropdowns](https://scikit-learn.org/stable/modules/linear_model.html#references) (anchor link for dropdown blocks; toggle-all button for Ctrl-F searching) - Algolia search (WIP): scikit-learn/scikit-learn#29666 - Many other CSS customizations Looking forward to your feedback :) *BTW some of the projects were not placed in alphabetical order as required so I reordered a bit.*
gabalafou
pushed a commit
to gabalafou/pydata-sphinx-theme
that referenced
this pull request
Oct 6, 2024
Thanks for the amazing theme! Scikit-learn has migrated to pydata-sphinx-theme for the main website since version 1.5 (scikit-learn/scikit-learn#29038), and the nice three-column layout has unlocked many potential improvements to our website UI/UX-wise. This PRs adds scikit-learn to the list of `Other projects using this theme`. However though scikit-learn is not one of the earliest adopters of pydata-sphinx-theme, I'm asking if it can fit into the list of `Featured projects` as we have many quite some customizations that could be helpful for other users of the theme. Some of them include: - [Landing page](https://scikit-learn.org/) - [API references](https://scikit-learn.org/stable/api/index.html) (a searchable table on the index page containing all APIs while keeping the hierarchy in the primary sidebar) - [Each API page](https://scikit-learn.org/stable/modules/generated/sklearn.linear_model.LogisticRegression.html) (customizing the secondary sidebar) - [Gallery examples](https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_5_0.html) (secondary sidebar customization with sphinx-gallery) - [Platform-specific installation instructions](https://scikit-learn.org/stable/install.html#installing-the-latest-release) (CSS customizations based on tabs in sphinx-design) - [Dropdowns](https://scikit-learn.org/stable/modules/linear_model.html#references) (anchor link for dropdown blocks; toggle-all button for Ctrl-F searching) - Algolia search (WIP): scikit-learn/scikit-learn#29666 - Many other CSS customizations Looking forward to your feedback :) *BTW some of the projects were not placed in alphabetical order as required so I reordered a bit.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is done mostly by @Charlie-XIAO , this is a PR to merge the work into the main branch.