MNT upgrade black version #28802
Merged
MNT upgrade black version #28802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We already use ruff. Why not migrate to using ruff instead? |
jeremiedbb
approved these changes
Apr 10, 2024
Member
jeremiedbb
left a comment
jeremiedbb
left a comment
There was a problem hiding this comment.
The changes look okay. LGTM.
Member
We can do this as long as we turn on Line 105 in 3fa732b Turning off preview means we opt out of black's string preprocessing. Ruff does not support string preprocessing right now: astral-sh/ruff#6936 Also the future of string preprocessing in black is uncertain: psf/black#4208 |
Member
Author
|
Should we merge then? This is the kind of PR which can't stay stale for long 😁 |
thomasjpfan
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by seeing recently that a few contributors ended up submitting changes unrelated to their PRs, realized we haven't updated our linting tools in a while.
Upgrades black version.
I'll submit another PR immediately after this to ignore these changes in our git ignore rev file.
cc @scikit-learn/core-devs