GOV add a documentation team #26714
GOV add a documentation team #26714
Conversation
There was a problem hiding this comment.
LGTM.
Thank you, @adrinjalali.
I think we can be liberal and trust people for making decision while recognizing their work and involvement in the project.
Here are some minor nitpicks.
There was a problem hiding this comment.
I think we can be liberal and trust people for making decision while recognizing their work and involvement in the project.
@jjerphan a governance document is a contract, and better be clear about peoples rights and responsibilities than not. So I rather not remove the part about the team being able to merge only doc PRs.
|
A vote was called on the mailing list. The voting period is one month and will conclude on August 10th. According to our governance docs, no changes can be made to this PR during the voting period. |
|
@agramfort : if I am not wrong, you have not had a look at this. If you are find with this change, would you mind approving it. |
|
Trying to solicit more approvals or discussion, @scikit-learn/core-devs : please approve this PR if you are fine with this change of our governance. It adds a documentation team that helps reviewing and merge documentation, in an effort to adapt to our broader team. |
|
We should be able to merge this one since the 1 month voting period is passed? |
|
Merging, and will give the @scikit-learn/documentation-team merge rights. Excited! I'll also send an email on our mailing list. |
|
Merged #26714 into main.
Wow!!
|
This PR proposes adding a documentation team to the governance model.
The initial members are proposed to be @ArturoAmorQ and @lucyleeow
Very happy to get feedback on the wording of the description of the team.
The team is already created on GH, but has no extra permissions till we merge this PR. I will call for a vote once an initial round of discussions are concluded here.