Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Update "About Us" #25435

Merged
merged 4 commits into from
Jan 20, 2023
Merged

DOC Update "About Us" #25435

merged 4 commits into from
Jan 20, 2023

Conversation

jjerphan
Copy link
Member

The scripts has been updated to filter @sklearn-lgtm and to make pre-commit happy.

@jjerphan jjerphan added Documentation Quick Review For PRs that are quick to review labels Jan 19, 2023
@ogrisel ogrisel added this to the 1.2.1 milestone Jan 19, 2023
ogrisel
ogrisel approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the circle ci to be green and merge.

@ogrisel ogrisel enabled auto-merge (squash) January 19, 2023 15:14
glemaitre
glemaitre reviewed Jan 19, 2023
View reviewed changes
doc/authors_emeritus.rst
@@ -27,7 +27,7 @@
- Peter Prettenhofer
- (Venkat) Raghav, Rajagopalan
- Jacob Schreiber
- Du Shiqiao
- 杜世橋 Du Shiqiao
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall well, I think that the rendering was not fine with Chinese characters. We need to check before merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and the rendering is fine

@ogrisel ogrisel disabled auto-merge January 19, 2023 15:52
@ogrisel
Copy link
Member

ogrisel commented Jan 19, 2023

If I recall well, I think that the rendering was not fine with Chinese characters. We need to check before merging.

I disabled the auto-merge.

@ogrisel
Copy link
Member

ogrisel commented Jan 19, 2023

The doc build was fine but the upload is either very slow or the generated zip is enormous:

image

@jjerphan
Copy link
Member Author

I have merge main in this PR branch with 2b50b6b to re-trigger the CI.

@ogrisel
Copy link
Member

ogrisel commented Jan 19, 2023 •
edited
Loading

The circle ci doc job failed because the download of the zip from https://pipelines.actions.githubusercontent.com was too slow. Probably a bad day for the Azure infrastructure used by github actions.

We might want to re-trigger the CI in a few hours.

@jjerphan @glemaitre
Respect Maxwell Liu's name
e1048d8 
Co-authored-by: Guillaume Lemaitre <[email protected]>
@glemaitre glemaitre merged commit 2248b4a into scikit-learn:main Jan 20, 2023
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@jjerphan @ogrisel @glemaitre
DOC Update "About Us" (scikit-learn#25435)
d1467f4 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@jjerphan @ogrisel @glemaitre
DOC Update "About Us" (scikit-learn#25435)
4d5c37d 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
@jjerphan @ogrisel @glemaitre
DOC Update "About Us" (scikit-learn#25435)
f690ce9 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
adrinjalali pushed a commit that referenced this pull request Jan 24, 2023
@jjerphan @ogrisel
@glemaitre @adrinjalali
DOC Update "About Us" (#25435)
2b3f385 
Co-authored-by: Olivier Grisel <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellLZH MaxwellLZH MaxwellLZH left review comments

@glemaitre glemaitre glemaitre left review comments

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jjerphan @ogrisel @glemaitre @MaxwellLZH