-
-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: various spellcheck and typos #23093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I prefer the American version, but I think is it because I am from the United States.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well. I also tend to use the american spelling. I'm not sure that we really need to enforce that, but I don't mind either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we tend to use the American conventions, e.g. sklearn.neighbors
, so +1 for me.
But I also think it's fine to keep the British notation here and there.
Other kinds of typos, that is real typos, should always be fixed though.
Reference Issues/PRs
None. Just a few typos and spellchecks I've found exploring the docs.
What does this implement/fix? Explain your changes.
Various typos found in the documentation
Any other comments?
I wasn't sure how to handle some of the American/British versions of things found in the docs (
visualize
orvisualise
;normalize
ornormalise
, etc.). If the British version is desired, I'd be happy to rework the commits to only have true typos.There are things that should be changed regardless of the american/british versions of words so please don't think this PR is just about that.
Happy to do what I can to make this correct/easy to reveiew.
Thanks!