Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: various spellcheck and typos #23093

Merged
merged 24 commits into from
Apr 12, 2022
Merged

DOC: various spellcheck and typos #23093

merged 24 commits into from
Apr 12, 2022

Conversation

loganthomas
Copy link
Contributor

Reference Issues/PRs

None. Just a few typos and spellchecks I've found exploring the docs.

What does this implement/fix? Explain your changes.

Various typos found in the documentation

Any other comments?

I wasn't sure how to handle some of the American/British versions of things found in the docs (visualize or visualise; normalize or normalise, etc.). If the British version is desired, I'd be happy to rework the commits to only have true typos.

There are things that should be changed regardless of the american/british versions of words so please don't think this PR is just about that.

Happy to do what I can to make this correct/easy to reveiew.

Thanks!

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I prefer the American version, but I think is it because I am from the United States.

@thomasjpfan thomasjpfan changed the title [MRG] DOC: various spellcheck and typos DOC: various spellcheck and typos Apr 9, 2022
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. I also tend to use the american spelling. I'm not sure that we really need to enforce that, but I don't mind either.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tend to use the American conventions, e.g. sklearn.neighbors, so +1 for me.

But I also think it's fine to keep the British notation here and there.

Other kinds of typos, that is real typos, should always be fixed though.

@ogrisel ogrisel merged commit f16c987 into scikit-learn:main Apr 12, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants