Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename triage team to contributor experience team #22970

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Rename triage team to contributor experience team #22970

merged 6 commits into from
Mar 31, 2022

Conversation

jeremiedbb
Copy link
Member

Fixes #21993

@jeremiedbb
Copy link
Member Author

I can't generate the authors table:

Traceback (most recent call last):
  File "build_tools\generate_authors_table.py", line 158, in <module>
    core_devs, emeritus, contributor_experience_team, comm_team = get_contributors()
  File "build_tools\generate_authors_table.py", line 55, in get_contributors
    reply = get(f"https://api.github.com/teams/{team_id}/members?page={page}")
  File "build_tools\generate_authors_table.py", line 37, in get
    reply.raise_for_status()
  File "C:\Users\J\miniconda3\envs\dev\lib\site-packages\requests\models.py", line 960, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.github.com/teams/11523/members?page=1

we're maybe using a too old github api version ?

@jjerphan
Copy link
Member

we're maybe using a too old github api version ?

Yes, the GitHub API changed since then.

@lorentzenchr
Copy link
Member

Which one should we pursue, this PR or #22971?

jeremiedbb
jeremiedbb commented Mar 28, 2022
View reviewed changes
build_tools/generate_authors_table.py

emeritus = members - core_devs - triage_team
emeritus = members - core_devs - contributor_experience_team - comm_team
emeritus_comm_team = {"reshamas"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is hard to define programatically, I guess we have to hard code it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we somehow use doc/communication_team_emeritus.rst?

Copy link
Member Author

@jeremiedbb jeremiedbb Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe this script is what generates communication_team_emeritus.rst :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

doc/communication_team.rst Outdated
Comment on lines 17 to 18
<a href='https://github.com/reshamas'><img src='https://avatars.githubusercontent.com/u/2507232?v=4' class='avatar' /></a> <br />
<p>Reshama Shaikh</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reshama is still in the comm team on github. Should we remove her from the comm team ?
ref #22942

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is fine to keep her. She may still pop in and help with the blog for instance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've hard coded that. She's still in the comm team but won't show up on the page

@lorentzenchr lorentzenchr mentioned this pull request Mar 28, 2022
Closed
lorentzenchr
lorentzenchr approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/contributor_experience_team.rst Show resolved Hide resolved
build_tools/generate_authors_table.py

emeritus = members - core_devs - triage_team
emeritus = members - core_devs - contributor_experience_team - comm_team
emeritus_comm_team = {"reshamas"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we somehow use doc/communication_team_emeritus.rst?

@lorentzenchr
Copy link
Member

@scikit-learn/contributor-experience-team Anyone for a 2nd review?
Among other purposes, this message is a test with the new name on github:wink:

cmarmo
cmarmo approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@cmarmo cmarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me.... the ping with the new name works! ;)

Perhaps @reshamas would like to have a look?
Thanks!

@lorentzenchr lorentzenchr added this to the 1.1 milestone Mar 29, 2022
@ogrisel
Copy link
Member

ogrisel commented Mar 31, 2022

I seems the doc artifact link is broken but the artifacts are actually published at:

https://output.circle-artifacts.com/output/job/97d4ad82-9d3d-4fa9-9b15-755e3d9caa77/artifacts/0/doc/_changed.html

(Maybe circle ci has changed?)

@jeremiedbb
Copy link
Member Author

jeremiedbb commented Mar 31, 2022 •
edited
Loading

I seems the doc artifact link is broken but the artifacts are actually published at:

#22931

ogrisel
ogrisel approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremiedbb
Copy link
Member Author

Let's merge then :)

@jeremiedbb jeremiedbb merged commit 7811a3a into scikit-learn:main Mar 31, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@jeremiedbb @glemaitre
Rename triage team to contributor experience team (scikit-learn#22970)
0d90b45
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Apr 29, 2022
@jeremiedbb @jjerphan
Rename triage team to contributor experience team (scikit-learn#22970)
4316a04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@GaelVaroquaux GaelVaroquaux GaelVaroquaux left review comments

@cmarmo cmarmo cmarmo approved these changes

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Change name of Triage Team
6 participants
@jeremiedbb @jjerphan @lorentzenchr @ogrisel @GaelVaroquaux @cmarmo