Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT remove sparse_lsqr from utils.fixes #22894

Merged
merged 1 commit into from
Mar 18, 2022
Merged

MNT remove sparse_lsqr from utils.fixes #22894

merged 1 commit into from
Mar 18, 2022

Conversation

lorentzenchr
Copy link
Member

What does this implement/fix? Explain your changes.

Remove the sparse_lsqr fix as lsqr is available from the minimum version of scipy.

jeremiedbb
jeremiedbb approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that also but you were faster :)

glemaitre
glemaitre approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorentzenchr lorentzenchr merged commit 99262c0 into scikit-learn:main Mar 18, 2022
@lorentzenchr lorentzenchr deleted the remove_sparse_lsqr branch March 18, 2022 20:14
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@lorentzenchr @glemaitre
MNT remove sparse_lsqr from utils.fixes (scikit-learn#22894)
e29ea50
@thomasjpfan thomasjpfan mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiedbb jeremiedbb jeremiedbb approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
module:linear_model module:utils No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @glemaitre @jeremiedbb