Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST Replace pytest.warns(None) in test_omp.py #22886

Merged
merged 1 commit into from
Mar 18, 2022
Merged

TST Replace pytest.warns(None) in test_omp.py #22886

merged 1 commit into from
Mar 18, 2022

Conversation

richardt94
Copy link
Contributor

Reference Issues/PRs

Related to #22572

What does this implement/fix? Explain your changes.

Replaces deprecated pytest.warns(None) in linear_model/tests/test_omp.py with a warnings.catch_warnings() context manager that specifically filters the (un)expected FutureWarning.

thomasjpfan
thomasjpfan approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@thomasjpfan thomasjpfan merged commit aee564c into scikit-learn:main Mar 18, 2022
@thomasjpfan thomasjpfan mentioned this pull request Mar 18, 2022
Closed
@richardt94 richardt94 deleted the test_omp_update branch March 22, 2022 04:21
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 6, 2022
@richardt94 @glemaitre
TST Replace pytest.warns(None) in test_omp.py (scikit-learn#22886)
aa3f2e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:linear_model No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardt94 @thomasjpfan