TST ensure that sklearn/_loss/tests/test_loss.py is seed insensitive #22847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
commented
Mar 15, 2022
jeremiedbb
approved these changes
Mar 15, 2022
Co-authored-by: Christian Lorentzen <[email protected]>
thomasjpfan
approved these changes
Mar 15, 2022
|
I feel honored that the loss module got picked as first PR towards #22827 😉 And I feel relieved that it passed! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
…cikit-learn#22847) Co-authored-by: Christian Lorentzen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22827
I only modified the tests that were testing mathematical properties of the loss implementations on random data. I skipped tests that are just about shapes, dtypes and error messages as they are unlikely to suffer from seed-sensitivity.
I launched:
on my local machine and all tests pass. Those tests are already seed-insensitive.