Doc : adds 4 points to sklearn.datasets._samples_generator.make_sparse_coded_signal #22817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Apparently this PR changes both load_sample_image and make_sparse_coded_signal which is probably not intentional.
This might happen when you create a new branch off of a non-main branch.
Always need to create your branch from the the main branch (ideally after having done a git pull upstream main to make sure that it's up to date with upstream).
This will allow you to work independently on several pull requests in parallel.
| @@ -1280,7 +1280,7 @@ def make_sparse_coded_signal( | |||
| code : ndarray of shape (n_components, n_samples) | |||
| The sparse code such that each column of this matrix has exactly | |||
| n_nonzero_coefs non-zero items (X). | |||
|
|
|||
There was a problem hiding this comment.
Those new trailing white-spaces make the code style linter fail in the CI report. Removing them will fix the problem:
Suggested change
|
Adding the #pariswimlds hashtag :-) |
jeremiedbb
added
No Changelog Needed
Quick Review
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #21350
What does this implement/fix? Explain your changes.
Adds 4 dots in the sklearn.datasets._samples_generator.make_sparse_coded_signal function.