Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX sphinx warning on @deprecated n_features_ property #20418

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jun 28, 2021

Follow-up on #20410 which should fix the remaining failures on Circle CI observed on #20412 and other PRs.

@ogrisel ogrisel requested a review from thomasjpfan June 28, 2021 17:49
@ogrisel ogrisel requested a review from glemaitre June 28, 2021 17:50
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
Copy link
Member Author

ogrisel commented Jun 28, 2021

Forgot to update the test...

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit d402cd1 into scikit-learn:main Jun 28, 2021
@ogrisel ogrisel deleted the fix-sphinx-warning-on-deprecated-tree-property-docstrings branch June 28, 2021 18:16
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants