Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

Merged
merged 102 commits into from
Mar 10, 2020
Merged

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

merged 102 commits into from
Mar 10, 2020

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented Nov 22, 2019 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR adds an example in the inspection section, about the interpretation of coefficients in linear models.

Any other comments?

The example makes use of the seaborn package. I've added it to the build on Circle CI. If there is no consensus about that, I will re-write the plot in matplotlib.

Steps to finalise this PR

  • Clarify marginal and conditional semantic
  • Add Scaler preprocessing for numerical variables and compare
  • Address unresolved comments

@cmarmo cmarmo changed the title DOC Add example about interpretation of coefficients of linear models [WIP] DOC Add example about interpretation of coefficients of linear models Nov 22, 2019
@cmarmo cmarmo changed the title [WIP] DOC Add example about interpretation of coefficients of linear models [MRG] DOC Add example about interpretation of coefficients of linear models Nov 25, 2019
@cmarmo
Copy link
Contributor Author

cmarmo commented Nov 25, 2019

@glemaitre , I think that the build on Azure failed for reasons having nothing to do with my changes...

@jnothman
Copy link
Member

jnothman commented Nov 25, 2019 via email

@jeremiedbb
Copy link
Member

It has been fixed on conda-forge side. Should be green now

NicolasHug
NicolasHug reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmarmo , this is a nice addition

Made a bunch of comments but mostly looks good.

To avoid data leaks, I think we need to split the dataset before doing any sort of exploration.

build_tools/circle/build_doc.sh Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
glemaitre
glemaitre reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first pass on the example.

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
@NicolasHug NicolasHug mentioned this pull request Feb 29, 2020
Open
@cmarmo cmarmo mentioned this pull request Mar 2, 2020
Merged
glemaitre
glemaitre reviewed Mar 10, 2020
View reviewed changes
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py Show resolved Hide resolved
@glemaitre
Copy link
Member

Apart of these glitches of rendering, LGTM

@glemaitre
Copy link
Member

Oh just a last thing, we should mention in the README.rst and install.rst that seaborn will be required as well for the example (next to the occurrence of matplotlib)

@glemaitre
Copy link
Member

I will merge when it is green.

@jnothman jnothman merged commit e9340e3 into scikit-learn:master Mar 10, 2020
@jnothman
Copy link
Member

Thank you @cmarmo for a wonderful addition to the documentation

@cmarmo cmarmo deleted the lincoeffinterpexample branch March 11, 2020 10:34
@cmarmo cmarmo mentioned this pull request Mar 12, 2020
Merged
ashutosh1919 pushed a commit to ashutosh1919/scikit-learn that referenced this pull request Mar 13, 2020
@cmarmo @NicolasHug
@GaelVaroquaux @jnothman @glemaitre @ashutosh1919
[MRG] DOC Add example about interpretation of coefficients of linear …
895cb6a 
…models (scikit-learn#15706)



Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Gael Varoquaux <[email protected]>
Co-authored-by: Joel Nothman <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@cmarmo @NicolasHug
@GaelVaroquaux @jnothman @glemaitre @gio8tisu
[MRG] DOC Add example about interpretation of coefficients of linear …
ad149f0 
…models (scikit-learn#15706)



Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Gael Varoquaux <[email protected]>
Co-authored-by: Joel Nothman <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@NicolasHug NicolasHug NicolasHug left review comments

@ogrisel ogrisel ogrisel left review comments

@jnothman jnothman jnothman left review comments

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cmarmo @jnothman @jeremiedbb @GaelVaroquaux @agramfort @NicolasHug @glemaitre @ogrisel