MRG Emeritus core devs on website #13468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only one team is used in org, removed some emeritus devs from list regenerated authors.rst
amueller
commented
Mar 18, 2019
| except IndexError: | ||
| # Without authentication: up to 60 requests per hour. | ||
| auth = None | ||
| # With authentication: up to 5000 requests per hour. |
There was a problem hiding this comment.
authentication is required for any of this script to work, regardless of quota.
|
also made Raghav an emeritus dev. A remaining question is maybe whether we want to remove the emeritus devs from the org entirely or just from the core dev group. Right now emeritus devs are basically those that are in the org but not the group. |
|
They can remove themselves from the org if they wish. I was wondering if we
should just include data about emeritus and still generate a page with
their profile pics
|
|
You mean hard-code them in the generate_authors_table and create a separate table for emeritus devs? Sure, we can do that. Will be harder to include "active dates" but not sure how practical that is anyway. |
|
I don't see why it's much harder to include active dates (but I agree it's
impractical). Happy with your practical approach :)
|
qinhanmin2014
approved these changes
Mar 21, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 5648cb7.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 5648cb7.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see #13257.
I added a new section "emeritus core devs" to the about page.
We could have that in authors as well, but then we would need to autogenerate it.
Given that @GaelVaroquaux wanted dates when people became active, I thought doing it explicitly might be better.
Also, I removed the historic "reviewers" group that hasn't been used, and dropped the emeritus core devs from the "core developers group" in the org.
We could have an "emeritus" group in the org, but that seems like just more email traffic for people not really associated with the project any more.
The criterion that I applied for determining who to message has been "hasn't voted in the governance vote and has not been active", so that's only a subset of those that we should email according to the governance doc, but I thought it would be a good start.