fix: adjust for Pandas changing its API again #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Uproot 5, we had
uproot5/src/uproot/interpretation/library.py
Lines 1131 to 1134 in b36a022
to allow for different Pandas APIs before and after Pandas 0.24. But Pandas 0.24 is ancient, and I decided that we don't need to handle that anymore in #734 (which made a lot of changes, removing the explode-to-Pandas behavior).
But at some point in recent history, the attribute switched from
Index.arraysback toIndex.values. There's anIndex.array, but it's a NumpyExtension, rather than a plain NumPy array, andnp.addmight prefer the real NumPy array.