Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Main Thread Checker issues #21

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix Main Thread Checker issues #21

merged 1 commit into from
Apr 30, 2018

Conversation

Sega-Zero
Copy link
Contributor

Since device motion updates are performed in opQueue, it is not safe to read or set ui properties in a handler.
Wrapped this code in DispatchQueue.main.async to resolve MainThreadChecker issues:
ctpanoramaview swift edited 2018-04-29 15-59-17
ctpanoramaview swift edited 2018-04-29 15-58-24

@Sega-Zero Sega-Zero mentioned this pull request Apr 29, 2018
Merged
@scihant scihant changed the title Fix Main Thread Checker issues Motion update handler no longer accesses the UI from another thread Apr 30, 2018
@scihant scihant merged commit ca01508 into scihant:master Apr 30, 2018
@scihant
Copy link
Owner

scihant commented Apr 30, 2018

Thanks for your contribution!

@scihant scihant changed the title Motion update handler no longer accesses the UI from another thread Fix Main Thread Checker issues Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sega-Zero @scihant