Test to close scala/bug#5075. #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
reviewed
Mar 3, 2018
test/files/pos/t5075.scala
Outdated
|
|
||
| function[PartialApply1Of2[Tuple2, Int]#Apply](param): Int //Compiles | ||
| function(param) //Does not compile | ||
| param: Int //Does not compile |
There was a problem hiding this comment.
Cool that it compiles now! Suspect those comments are stale 😉
S11001001
reviewed
Mar 3, 2018
test/files/pos/t5075.scala
Outdated
| trait PartialApply1Of2[T[_, _], A] { | ||
| type Apply[B] = T[A, B] | ||
|
|
||
| type Flip[B] = T[B, A] |
There was a problem hiding this comment.
Was Flip to be used for something?
There was a problem hiding this comment.
Guess I just forgot to minimize it away in 2011. But it's useful for your comment scala/bug#5075 (comment).
There was a problem hiding this comment.
@Blaisorblade I suspect that a modern minimization of 5075 would use Flip instead, no?
There was a problem hiding this comment.
Of course, I already upvoted your comment! (Nitpick: I'd add testcases with Flip in addition.)
adriaanm
suggested changes
Apr 11, 2018
|
I updated the test file. |
adriaanm
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed, most likely by the SI-2712 fix.