allow Windows REPL default -Dscala.color=auto to show colors #10979
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
added
prio:hi
|
wow, really nice testing, you for that!! |
SethTisue
reviewed
Jan 9, 2025
| @@ -141,7 +141,7 @@ private[scala] trait PropertiesTrait { | |||
| /* Some runtime values. */ | |||
| private[scala] lazy val isAvian = javaVmName.contains("Avian") | |||
|
|
|||
| private[scala] def coloredOutputEnabled: Boolean = propOrElse("scala.color", "auto") match { | |||
| private[scala] def coloredOutputEnabled: Boolean = propOrElse("scala.color", "true") match { | |||
| case "auto" => !isWin && consoleIsTerminal | |||
There was a problem hiding this comment.
This is a different change than I would have expected. I would think we'd want to leave auto as the default, but remove the !isWin && from line 145?
There was a problem hiding this comment.
apparently, tests are not colorized, for example. That's a lot of tests broken by so few chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the change proposed in bug/issues/13077.
It addresses this
scala-clibug : scala-cli/issues/#3394The change was manually verified by confirming color is enabled by default:
Command Prompt session in Windows Terminal
CMD.EXEsessionMSYS64 bash shell
CYGWIN session running in Windows Terminal
CYGWIN session in MINTTY console
Git Bash session in Windows Terminal
MINGW64 in Windows Terminal
WSL2 Ubuntu Linux session
Verified that color can be disabled on the command line:
