no more Travis-CI for PR validation, use GitHub Actions #10961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doing so is overkill. it's fine to just build the spec nightly. spurious failures are vastly more common than real failures in this.
SethTisue
added
the
internal
oh, wow: on Travis-CI we see PR validations on the 2.12.x branch taking ~1h5m, for example this run but the GHA run here finished in just 33m 🚀 this level of speedup will be even more welcome on 2.13.x, where the Travis-CI PR validation times are considerably longer (~1h50m) |
|
wdyt @lrytz @som-snytt ? |
SethTisue
force-pushed
the
get-travis-ci-out-of-pr-validation
branch
from
eb49f4f to
9761bae
Compare
|
the cycle 🚲 is faster now |
|
The merge onto 2.13.x isn't completely straightforward, so I might not get to it until January sometime. |
|
I'll submit an independent forward-port PR rather than including it in a routine batch merge. |
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, do not build the spec during PR validation, doing so is overkill and spurious failures have been an ongoing annoyance. nightly ("mergely") is fine for this
this doesn't eliminate Travis-CI entirely. it will still publish nightlies and publish the spec. (for now, anyway.) for context on that, and for why we also keep Jenkins, see scala/scala-dev#751
we could have made this limited change (to PR validation only) ages ago, but it didn't seem like a priority
but
and also, it dawned on me today that this might actually be quite easy, so why not just go ahead and try it?
cc @He-Pin who asked about this recently — the question got me thinking