Upgrade scalapb machinery to modern version #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @slandelle! |
eed3si9n
requested changes
Nov 2, 2019
slandelle
force-pushed
the
sbt-protoc-upgrade
branch
from
504fe55 to
3934d9c
Compare
eed3si9n
reviewed
Nov 2, 2019
slandelle
force-pushed
the
sbt-protoc-upgrade
branch
from
3934d9c to
fdb0d67
Compare
Motivation: Protobuf machinery currently uses com.trueaccord.scalapb:compilerplugin which is the old groupId and is not available for Scala 2.13. Modifications: * Upgrade com.thesamet:sbt-protoc to 0.99.26 * Switch to com.thesamet.scalapb:compilerplugin 0.9.3 * Remove com.google.protobuf:protobuf-java forced version upgrade as version now pulled is 3.8.0 * Update mima excludes Note: * scala-maven-plugin test suite passes with Scala 2.12 build with those changes. Result: Zinc now uses a modern version of scalapb, where a crosscompiled version for Scala 2.13 is available.
slandelle
force-pushed
the
sbt-protoc-upgrade
branch
from
fdb0d67 to
01d4d6f
Compare
@eed3si9n fixed! |
eed3si9n
approved these changes
Nov 2, 2019
|
@eed3si9n BTW, why is dev HEAD version 1.3.0-SNAPSHOT while 1.3.1 is out? |
|
I guess that's just how sbt-dynver calculates the version until we tag it. develop would be Zinc 1.4.x or 2.x. |
|
Thanks for merging! |
You need to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546
Motivation:
Protobuf machinery currently uses com.trueaccord.scalapb:compilerplugin which is the old groupId and is not available for Scala 2.13.
Modifications:
Note:
Result:
Zinc now uses a modern version of scalapb, where a crosscompiled version for Scala 2.13 is available.